Closed devTeaa closed 2 years ago
I'm not really sure about the Error, is the one I pushed correct?
Also sorry, but husky broke for me too, didn't mean to skip the hooks, and now I can't rebase and edit message since I have to remove husky and after editing it is says I have uncommited changes (deleting husky). I'll squash everything into one commit before merging later. I have to checkout to version before stylelint 14, run test, and move the changes to upstream branch, sorry again for long response
I'm not really sure about the Error, is the one I pushed correct?
Also sorry, but husky broke for me too, didn't mean to skip the hooks, and now I can't rebase and edit message since I have to remove husky and after editing it is says I have uncommited changes (deleting husky). I'll squash everything into one commit before merging later. I have to checkout to version before stylelint 14, run test, and move the changes to upstream branch, sorry again for long response
@devTeaa Okay.
Regarding the Error I would support errors thrown as:
throw "some error";
Error
constructor, e.g. throw new Error("some error");
Regarding Husky you can always skip git hooks, e.g. with --no-verify
.
Hi @devTeaa I haven't heared back from you in a while. So I addressed the required changes myself.
Thank you very much for the issue and your willingsness to help out.
Will close this PR in favor of #254.
Sorry, @AndyOGo really hard for me to do with broken env on my local pc thanks for doing it tho
This PR allows autoFixFunc to throw error (ex: when switch statement is not found or matched) as requested on this issue #251
Currently if autoFixFunc is supplied, it can't throw error if the prop is not being handled, this way the devs has options to throw error if it happens