AndyOGo / stylelint-declaration-strict-value

Specify properties for which a variable, function, keyword or value must be used.
MIT License
133 stars 10 forks source link

chore(deps-dev): bump typedoc from 0.22.7 to 0.26.5 #376

Closed ybiquitous closed 2 months ago

ybiquitous commented 2 months ago

This PR fixes the dependency installation error below:

npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: stylelint-declaration-strict-value@1.10.4
npm error Found: typedoc@0.22.18
npm error node_modules/typedoc
npm error   dev typedoc@"^0.22.7" from the root project
npm error
npm error Could not resolve dependency:
npm error peer typedoc@">=0.24.0" from typedoc-plugin-markdown@3.17.1
npm error node_modules/typedoc-plugin-markdown
npm error   dev typedoc-plugin-markdown@"^3.2.1" from the root project

Ref https://github.com/stylelint/stylelint-ecosystem-tester/actions/runs/10136076046/job/28024366171#step:8:1

AndyOGo commented 2 months ago

Thx for creating a PR @ybiquitous

This project should ideally have a package-lock file, because typedoc-plugin-markdown@3.2.1 requires typedoc >= 0.20.0 🤔 https://github.com/typedoc2md/typedoc-plugin-markdown/blob/e6fe456e9aa342782ea3d32b7d27e55302a08899/packages/typedoc-plugin-markdown/package.json#L42-L44

And any breaking changes within typedoc-plugin-markdown shouldn't be released as minor or patch versions.

AndyOGo commented 2 months ago

@ybiquitous Thanks for helping out.

I decided to approach this issue by committing the package-lock.json file.

I released v1.10.6.

This should workaround the issue of typedoc-plugin-markdown not bumping their major version for breaking changes.

ybiquitous commented 2 months ago

@AndyOGo Thank you. The new version's test now passed! ✅ https://github.com/stylelint/stylelint-ecosystem-tester/actions/runs/10153815628/job/28077873454