search

AndyQ / NFCPassportReader

NFCPassportReader for iOS 13
MIT License
733 stars 235 forks source link

extract.py: Fails for `.ml` files #203

Closed matthiasgeihs closed 2 months ago

matthiasgeihs commented 5 months ago

First of all: Great project!

I stumbled across a minor bug when reading .ml files with the extract.py script.

https://github.com/AndyQ/NFCPassportReader/blob/84e11ec67a5c0d5ff54f918182fd4658801cc7f2/scripts/extract.py#L29-L42

For .ml files, the variable cns is not set, and hence the script fails at line 37.

AndyQ commented 5 months ago

Hi @matthiasgeihs Can you give an example of an ml list that fails? (or a location I can get one from?)

matthiasgeihs commented 5 months ago

If I see it correctly, this fails for all .ml files. Concretely, I was testing with the German CSCA Master List.

AndyQ commented 3 months ago

I've just fixed this - its in main and will be in the next release

matthiasgeihs commented 3 months ago

Feel free to close the issue whenever you feel like it. 🙂