AndyQ / NFCPassportReader

NFCPassportReader for iOS 13
MIT License
733 stars 235 forks source link

iOS 17.4 nfc popup allows to cancel already failed scanning session #210

Open Thormeard opened 3 months ago

Thormeard commented 3 months ago

Seems like iOS 17.4 introduced slightly updated popup design for the nfc scanning.

Previously if you had an error while scanning - it was printing an error without the cancel button, and popup closes itself after a ~1second. With the 17.4 if you have an error - cancel button (and X in the corner) is still there and can be pressed (popup still closes itself). And what happens is that you have an error, click cancel - and you have an UserCanceled event on top of the error after a few seconds, which cancel next scanning session that is being started (if you pressed restart for example).

How to reproduce:

Suggestion:

Also minor visual thing - in the iOS 17.4 DisplayMessage (status of scanning) can only contain 2 lines of text. And custom progress bar (made of 🟢) is separated from the text by empty line which pushes progress bar to line 3 which is not visible. I tried to remove 1 spacer - looks too close to the status text.. I don't know if this is a bug or apple decided that 2 lines of text is enough, but reporting just so that you know about it. I would keep it as it is for a while until we going to be sure that 2 lines is here to stay.