AndyQ / NFCPassportReader

NFCPassportReader for iOS 13
MIT License
733 stars 235 forks source link

Sensitive data in logs #220

Closed nasko25 closed 2 months ago

nasko25 commented 3 months ago

Is there any log level that is guaranteed to not include any personal information (like BAC key, any data group information, etc.) that could be safely shared when debugging?

AndyQ commented 2 months ago

Hmmm good question - Info shouldn't but I'm not 100% sure it doesn't. Ideally I would be masking out any sensitive data with an option to include it if necessary for all debug levels (its on my list to do)

nasko25 commented 2 months ago

I see, that would be a great feature. Thank you.

Also, I noticed that the error level might contain sensitive data, which I would have assumed it wouldn't. Info level appears safe to me as well.