search

AndyReckt / Holiday

This is an old free Server Core i made, there is no more support for this plugin but feel free to fork or open issues/pr, i may read them!
GNU General Public License v3.0
34 stars 7 forks source link

isOnline key is checked but never set #86

Open robot7boy opened 1 year ago

robot7boy commented 1 year ago

Hello, I apologize for the issue report. I could not find a way to contact you due to discord friend requests being off. I have never submitted an issue report before so I apologize if I am doing something wrong.

I have noticed that, although the isOnline key is being checked, it is actually never set when a player joins from what I can tell. This causes players to not be detected as online even though they are. This means that I cannot pull players, message players, and I can kick players that aren't even online.

I just thought I would throw this out there. If I am wrong, I would love to get ahold of you so we can find a solution to my issue.

Keep up the amazing work! If I could find a way to donate to the development of this core I would definitely do so.

robot7boy commented 1 year ago

Sorry for the accidental close. I fixed the message part, I think it was a bug when I compiled or something? anyways I can still kick "offline" players. I also can never pull players because it constantly states they are offline. I still would love to help pay to keep development going

robot7boy commented 1 year ago

Last thing hopefully, fingers crossed.

I installed and configured both the bungee, staff, and bukkit plugins and when staff join I recieve the error "Cannot invoke "me.andyreckt.holiday.api.server.IServer.getServerName()" because the return value of "me.andyreckt.holiday.api.API.getServer(String)" is null"

AndyReckt commented 1 year ago

hello @robot7boy you can add me on discord at @andyreckt since discord changed their user tags

AndyReckt commented 1 year ago

also thank you for the issue report, i will check later, but as you can see i no longer really update holiday as i am focusing on other projects so it might take a while. feel free to make a pr if you want to fix it youself