search

AndyTaylorTweet / Pi-Star_Binaries_sbin

Repository for Pi-Star Binaries
http://www.mw0mwz.co.uk/pi-star/
43 stars 41 forks source link

While overriding XLXHosts.txt, the match pattern should be the XLX se… #5

Closed yngwiechou closed 6 years ago

yngwiechou commented 6 years ago

Hello Andy,

Not sure if this is your original intention, but IP address will not be overridden by matching the IP address.

Regards, Yngwie Chou

yngwiechou commented 6 years ago

I'll cancel this pull request and raise another later, since the '^' REGEXP is missing in this change.

AndyTaylorTweet commented 6 years ago

I'm matching based on IP address on purpose, this is not a way to add new XLX hosts, it's purpose is to enable the over-ride of the default connected port/room, if I match on the XLX ID, you could choose to over-ride the connected IP address, and thats not the intention here.

What I may do is only allow you to specify the XLX Host ID and Room/Port number, so that I don't replace the host detail at all, but this was a quick and dirty hack to solve an immediate problem :)