While working on the file transfer I noticed I had not created an interface for managers. If a new manager was to be created, the following interface would have to be used (based on the attributes/methods created to implement FileSession):
This still has to be improved as these attributes/methods are not abstract enough and might cause issues in the future.
Another change is that parse class methods should be created so that the logic of parsing received elements move from ElementParser to their respective manager. ElementParser should be used just as a mapper from element to manager, like the new _parse_file*_element methods.
Finally, these managers should be renamed from *Session to *Manager and leave it up to each manager if they support single or multiple sessions.
While working on the file transfer I noticed I had not created an interface for managers. If a new manager was to be created, the following interface would have to be used (based on the attributes/methods created to implement
FileSession
):This still has to be improved as these attributes/methods are not abstract enough and might cause issues in the future.
Another change is that parse class methods should be created so that the logic of parsing received elements move from
ElementParser
to their respective manager.ElementParser
should be used just as a mapper from element to manager, like the new_parse_file*_element
methods.Finally, these managers should be renamed from
*Session
to*Manager
and leave it up to each manager if they support single or multiple sessions.