AnemoneLabs / unmessage

Privacy enhanced instant messenger
GNU General Public License v3.0
43 stars 7 forks source link

Make integration of the CLI and reactor #68

Closed felipedau closed 7 years ago

felipedau commented 7 years ago

During initial development, unMessage did not use Twisted and there wasn't a notion of a reactor. When Twisted started to be used, I chose to run the reactor in one of the methods of Peer and that is completely wrong. The Peer() constructor should receive a reactor installed by whatever is instantiating it. The CLI should install the reactor and be implemented as in carml's console.

felipedau commented 7 years ago

This has been fixed in 44d0ee8af6fbce71f0c7ba048799aec4c6fe908e.