AnemoneLabs / unmessage

Privacy enhanced instant messenger
GNU General Public License v3.0
42 stars 7 forks source link

Make integration of the GUI and reactor #69

Closed felipedau closed 7 years ago

felipedau commented 7 years ago

During initial development, unMessage did not use Twisted and there wasn't a notion of a reactor. When Twisted started to be used, I chose to run the reactor in one of the methods of Peer and that is completely wrong. The Peer() constructor should receive a reactor installed by whatever is instantiating it. The GUI should install the reactor as in Twisted's reactor integration howto.

felipedau commented 7 years ago

This has been fixed in 89702f9a0157cf8021194286d70a19d694970fa1.