Anexen / pyxirr

Rust-powered collection of financial functions.
https://anexen.github.io/pyxirr/
The Unlicense
172 stars 16 forks source link

Ran clippy and applied its suggestions #50

Closed amotzop closed 10 months ago

amotzop commented 10 months ago

I ran clippy and applied most of its suggestions (all except one that I wasn't sure how to fix/was "to big" of a fix)

Anexen commented 10 months ago

The remained warning was

warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
   --> src/conversions.rs:217:19
    |
217 |     pub fn to_vec(self) -> Vec<f64> {
    |                   ^^^^
    |

I fixed it by renaming to_vec to into_vec since I want to "consume" variable here.