Missing whitespace between data declaration and data

[GiorgioRuvolo]

In the latest version the declaration of data in the .data section when formatted does not leave a space between the data type and its value resulting in errors when executing the code.

[AngaBlue]

Hi, can you please provide a sample that will be incorrectly format so I can reproduce the issue?

[AngaBlue]

I've tried a few combinations of data types, label lengths etc but still haven't been able to replicate this issue. Please re-open it if you are able to provide a sample.

[GiorgioRuvolo]

this is before formatting :

[image: image.png]

after formatting it gets like this: [image: image.png]

and cause troubles because winmips does not recognize the data type

Il giorno sab 11 nov 2023 alle ore 04:08 Anga @.***> ha scritto:

Closed #4 https://github.com/AngaBlue/asm-formatter/issues/4 as not planned.

— Reply to this email directly, view it on GitHub https://github.com/AngaBlue/asm-formatter/issues/4#event-10931103091, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD2Q2XTRSA4FRQO54SAUNYDYD3T3BAVCNFSM6AAAAAA7DGFCMWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHEZTCMJQGMYDSMI . You are receiving this because you authored the thread.Message ID: @.***>

[AngaBlue]

Hi, I don't think you attached any images here.

[GiorgioRuvolo]

The highlighted one is before formatting, the other is after, the space that is eliminated is crucial for the correct interpretation of the data

Il lun 13 nov 2023, 12:51 Anga @.***> ha scritto:

Hi, I don't think you attached any images here.

— Reply to this email directly, view it on GitHub https://github.com/AngaBlue/asm-formatter/issues/4#issuecomment-1808013822, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD2Q2XRK5L2R3TD364WQCITYEICT5AVCNFSM6AAAAAA7DGFCMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBYGAYTGOBSGI . You are receiving this because you authored the thread.Message ID: @.***>

[AngaBlue]

Hi, you have still not uploaded the images. Please upload the images because I do not know what you're talking about. If you can't upload an image, paste the text in a code block or a gist.

[GiorgioRuvolo]

I am attaching the screenshots, I don't know why you can't see them I try again to attach them in this mail, if still doesn't work I will try with copying the text. Let me know if you can see the attached files, thank you

Il lun 13 nov 2023, 13:33 Anga @.***> ha scritto:

Hi, you have still not uploaded the images. Please upload the images because I do not know what you're talking about. If you can't upload an image, paste the text in a code block or a gist.

— Reply to this email directly, view it on GitHub https://github.com/AngaBlue/asm-formatter/issues/4#issuecomment-1808082094, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD2Q2XQMSMPLQ34KSGQLN43YEIHS5AVCNFSM6AAAAAA7DGFCMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBYGA4DEMBZGQ . You are receiving this because you authored the thread.Message ID: @.***>

[AngaBlue]

Unfortunately attaching screenshots doesn't appear to work.

[GiorgioRuvolo]

this is the non formatted code that works fine :

Here the formatted one that causes problems:

hoping this time images are clear, let me know if you can see them. Thank you.

[AngaBlue]

Thank you for the example. I'll work on a fix for this.

[GiorgioRuvolo]

Thank you, and sorry for the trouble uploading the examples, first time for me on GitHub

Il lun 13 nov 2023, 13:59 Anga @.***> ha scritto:

Thank you for the example. I'll work on a fix for this.

— Reply to this email directly, view it on GitHub https://github.com/AngaBlue/asm-formatter/issues/4#issuecomment-1808119885, or unsubscribe https://github.com/notifications/unsubscribe-auth/BD2Q2XVF7GUTAB5ICLPQ6Q3YEIKTZAVCNFSM6AAAAAA7DGFCMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBYGEYTSOBYGU . You are receiving this because you authored the thread.Message ID: @.***>

[AngaBlue]

This issue should be fixed in v1.2.4. Thanks for the report!

[BerserkVl]

the issue still exists Before:

After:

P.S. yes i am using the last version(1.2.4)

[AngaBlue]

Thanks, I didn't account for .data segment following the .text segment. Please try version 1.2.5.

[BerserkVl]

Thanks, I didn't account for .data segment following the .text segment. Please try version 1.2.5.

Thank you.

[ucxk]

This issue persists. Using v1.2.8.

[AngaBlue]

Hi @ucxk can you please give a sample to reproduce this issue?

[ucxk]

Of course, .section and .global should be whitespaced with the next word, but the formatter gets rid of them.

Before:

After:

Hope this helps.

[AngaBlue]

Hi @ucxk , thanks for the report. I've pushed a fix in v1.2.9, hopefully this resolves the issue. Please let me know if it doesn't.

[ucxk]

Working great! Thank you @AngaBlue