Add support for defining RequireJS packages (patch included)

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Compile a soy template with a new option specified 
(--shouldWrapWithRequireDefFunction)

What is the expected output? What do you see instead?
The output JS should be wrapped in a "require.def" function, specifying package 
a slash delimited version of the namespace.  The output should also include a 
dependency on the soy_utils.js file

What version of the product are you using? On what operating system?
Not Applicable

Please provide any additional information below.
I've included a patch to add this functionality, and would greatly appreciate 
it being incorporated upstream

Thanks!

Original issue reported on code.google.com by jamonter...@gmail.com on 17 Sep 2010 at 2:15

Attachments:

• add_support_for_requirejs.patch

[GoogleCodeExporter]

Sorry, I accidentally created this as a defect instead of an enhancement... and 
I don't seem to be able to change it.

Original comment by jamonter...@gmail.com on 17 Sep 2010 at 2:16

[GoogleCodeExporter]

Updated with the ability to specify the dependencies on the command line, 
rather than having them hard coded

Original comment by jamonter...@gmail.com on 17 Sep 2010 at 4:25

Attachments:

• add_support_for_requirejs_v2.patch

[GoogleCodeExporter]

We decided not to add requirejs support at this time, since it's (a) not part 
of Closure Tools and (b) not a de facto standard. But we'll keep an eye on it.

Original comment by kai.hu...@gmail.com on 25 Oct 2010 at 10:24

• Added labels: Priority-Low, Type-Enhancement
• Removed labels: Priority-Medium, Type-Defect

[GoogleCodeExporter]

That makes sense.  I'll play with this a bit more and see if I can come up with 
a generic way of decorating the output code that would work for requirejs, 
goog.provide, and any other future libraries in the space.

I'll update if I come up with something clean for it.  Thanks!

Original comment by jamonter...@gmail.com on 26 Oct 2010 at 12:41

[GoogleCodeExporter]

requireJS has now updated their API to conform to a commonJS asynchronous 
module definition proposal at 
http://wiki.commonjs.org/wiki/Modules/AsynchronousDefinition.  It's currently 
being used by RequireJS, Nodules, Dojo, Transporter, and partially implemented 
in Yabble as well.  I'm planning to update patch to conform to that as well, 
and I'll repost once that is done.

I look forward to your feedback on whether this would be accepted now that it 
is becoming a standard.

Thanks,
Jamon

Original comment by jamonter...@gmail.com on 15 Nov 2010 at 4:51

[GoogleCodeExporter]

I've updated my patch based on commonJS proposal.  Thanks in advance for 
considering this patch.

Jamon

Original comment by jamonter...@gmail.com on 15 Nov 2010 at 5:32

Attachments:

• useCommonJsAsyncDef.patch

[GoogleCodeExporter]

accidentally forgot to update based to use "define" instead of "require.def", 
here's the updated version:

Original comment by jamonter...@gmail.com on 15 Nov 2010 at 5:38

Attachments:

• useCommonJsAsyncDef.patch

[GoogleCodeExporter]

Thanks for the info and the patches. However, Closure Templates is not 
currently set up to take in contributions from people not at Google.

Your patch will still be useful, though, because other users looking up this 
issue can download your patch and apply it locally.

Original comment by kai.hu...@gmail.com on 19 Nov 2010 at 2:44

[GoogleCodeExporter]

Closure Templates has migrated to GitHub: 
https://github.com/google/closure-templates. Please reopen this there if it's 
still an issue.

FYI, the project can now accept pull requests.

Original comment by brendan....@gmail.com on 27 Feb 2015 at 12:14

• Changed state: WontFix