search

AngelFP / VisualPIC

Data Visualization for Particle-in-Cell Codes.
GNU General Public License v3.0
47 stars 13 forks source link

Close issue #8 Adding a setup.py for VisualPIC #10

Closed RemiLehe closed 6 years ago

RemiLehe commented 6 years ago

This PR adds a setup.py to VisualPIC. This allows in particular to launch visualPIC from any directory, by simply typing visualPIC in the command line.

@AngelFP I tested this on linux, but could you give it a try on Windows? Thanks!

ax3l commented 6 years ago

@RemiLehe did you forget to add the actual setup.py file?

RemiLehe commented 6 years ago

Oops...

RemiLehe commented 6 years ago

It's there now. Thanks for checking @ax3l !!

ax3l commented 6 years ago

Thanks for adding the file! :) Looks good to me!

AngelFP commented 6 years ago

Hi all, I finally had some time for this and I think it should be working now. There were some issues before, like some files missing (icons, colormaps, etc.) because they were not included in the the package_data.

I've also completed a bit more the setup file and made some further changes in order to create a suitable package for PyPI. I assigned a version number 0.3.2 and it's now already available online, so you should be able to install it simply with pip install visualpic.

Also, for the moment I decided to leave openpmd-viewer as optional, since the current available version in pip still has the Windows issues and stops the installation. Once the new version is uploaded I'll include it in the requirements file.

By the way, since I'm still not really a git expert... is it safe in this case to change the base branch of this PR from master to dev?

RemiLehe commented 6 years ago

Thanks for all these improvements @AngelFP. It's great that visualPIC is accessible from pypi!

I just released a new version of openPMD-viewer - version 0.8.1 - (which includes the Windows fixes) and uploaded on pypi. Could you check that this works for you?

Also: yes, you can safely change the base branch to dev. (In fact, I just did it.)

AngelFP commented 6 years ago

Thanks for checking the text @ax3l, I think it should be fine now. I've added back openpmd-viewer as a requirement and I have uploaded a new version of visualpic to pypi. So far everything seems to work well on my pc in windows and ubuntu.

RemiLehe commented 6 years ago

Great, thanks! I suggest that this PR be merged then. Would that be fine with you @AngelFP ?

AngelFP commented 6 years ago

Yep, all fine! Thanks to both of you for your work :D