search

AngelFP / VisualPIC

Data Visualization for Particle-in-Cell Codes.
GNU General Public License v3.0
47 stars 13 forks source link

Adding visualizer classes to __init__ forces to install `pyqt5`, etc. #41

Closed delaossa closed 1 year ago

delaossa commented 1 year ago

Calling the classes VTKVisualizer and MplVisualizer in init.py : https://github.com/AngelFP/VisualPIC/blob/18245da9ce2a3d1eded8bc7df28ca02dfa9255a4/visualpic/__init__.py#L6 will force you to install the extra packages that they need (pyqt5, vtk, pyvista). Otherwise a ModuleNotFoundError will be thrown.

AngelFP commented 1 year ago

Thanks @delaossa! This should fix it (#42). I think the issue was only with pyqt5 (due to the new MplVisualizer). The VTKVisualizer has been in the __init__.py for a long time now without issues.

delaossa commented 1 year ago

Thank you @AngelFP ! 👍