search

AngelLM / Thor

DIY 3D Printable Robotic Arm
Creative Commons Attribution Share Alike 4.0 International
928 stars 223 forks source link

The main change is the Art1BodyP3 #57

Closed wgaonar closed 7 years ago

wgaonar commented 7 years ago

There are so many changes but the only important is related with the split of Art1BodyP3 in 2 parts

AngelLM commented 7 years ago

wow, it will take me a while to see what changed! Will be merged soon ;)

wgaonar commented 7 years ago

Hello Angel. Yes I now.

I believe that it is better only to splitt the Art1BodyP3. Because I am reorganizing all the files in a customize fashion.

The important issue is that it would be a better solution for printing.

El 17 abr. 2017 3:49 PM, "AngelLM" notifications@github.com escribió:

wow, it will take me a while to see what changed! Will be merged soon ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AngelLM/Thor/pull/57#issuecomment-294588839, or mute the thread https://github.com/notifications/unsubscribe-auth/ABn5jTDD7bswT99wM-mU51x6uRhKNJEcks5rw9BcgaJpZM4M-uD8 .

AngelLM commented 7 years ago

Hi @wgaonar , Will you mind if we do this step by step? I'm not a master (yet) of git and I don't really know how to manage many commits in only one PR. If you don't mind, create a new branch synchronized with my current repo, then add the files of the splitted Art1Body part, commit and pull in that branch and after that send me the PR from that branch. In this way you will can update the repo with the new Art1Body design without merging the rest of the files ;)

Ask if you need help with this ;) Thank you very much!

wgaonar commented 7 years ago

Yeah it is the best solution. I must confess that I am new to GitHub too. I will do that you suggested

El 18 abr. 2017 9:39 AM, "AngelLM" notifications@github.com escribió:

Hi @wgaonar https://github.com/wgaonar , Will you mind if we do this step by step? I'm not a master (yet) of git and I don't really know how to manage many commits in only one PR. If you don't mind, create a new branch synchronized with my current repo, then add the files of the splitted Art1Body part, commit and pull in that branch and after that send me the PR from that branch. In this way you will can update the repo with the new Art1Body design without merging the rest of the files ;)

Ask if you need help with this ;) Thank you very much!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AngelLM/Thor/pull/57#issuecomment-294865766, or mute the thread https://github.com/notifications/unsubscribe-auth/ABn5jdC0wmaTXRI1yZcZx9kN6mYKvDdZks5rxMsVgaJpZM4M-uD8 .

AngelLM commented 7 years ago

Perfect, then I'll close this PR and will wait for the new ones ;)

I tried (in other different repo) to do this:

  1. Add a remote using: git remote add origin https://github.com/AngelLM/Thor
  2. Go to the remote dev branch: git checkout origin/developer
  3. Create a new branch based in this one: git checkout -b syncbranch
  4. Add the new files
  5. Commit them
  6. Send a pull request

Hope it helps!