search

AngelMunoz / Perla

A cross-platform tool for unbundled front-end development that doesn't depend on Node or requires you to install a complex toolchain
https://perla-docs.web.app/
MIT License
131 stars 12 forks source link

Respect Comments in perla.jsonc and perla.jsonc.lock #48

Closed AngelMunoz closed 2 years ago

AngelMunoz commented 3 years ago

Describe the bug We're allowing comments in perla.jsonc but when every time we add dependencies or the CLI modifies the file they get stripped out since we have a "skip" policy on the jsonSerializerOptions that we're using

To Reproduce Steps to reproduce the behavior:

  1. Do add a new package
  2. Comments are removed

Expected behavior Comments should not be deleted or moved from the perla.jsonc and perla.jsonc.lock files

AngelMunoz commented 2 years ago

at this point in time there is no built-in way to do this in .NET's JSON serializer it allows comments and things like that but just for parsing and deserializing not re-serializing so I don't think I'll invest more time in this in the forseable future