search

AngelMunoz / Perla

A cross-platform tool for unbundled front-end development that doesn't depend on Node or requires you to install a complex toolchain
https://perla-docs.web.app/
MIT License
131 stars 12 forks source link

Re-generate Lock file #71

Closed kaeedo closed 2 years ago

kaeedo commented 2 years ago

Hello. I wanted to try and contribute and started with this small feature: https://github.com/AngelMunoz/Perla/issues/56

Regenerating the lockfile currently works by going through the packages and adding them one by one.

Only open question I have would be what the command should be. Currently it's perla regenerate-lockfle.

AngelMunoz commented 2 years ago

Hey there! thanks for the initiative! I'll give it a check in the next few days (sorry for the delay)

I think restore is a good candidate for the command name as well, the lock file isn't really a lock file (my bad, I mixed some terminology there) it's just an import map, so "restoring the import map" in case it was deleted feels more accurate

kaeedo commented 2 years ago

I renamed to command to restore.

Also take all the time you want. No need to rush things.

AngelMunoz commented 2 years ago

hey! this one looks good to go! could you just run dotnet tool restore and dotnet fsi ./build.fsx -t Format and commit the formatted changes? after that I will merge it :)

AngelMunoz commented 2 years ago

hey @kaeedo would you happen to know which regex can we use in parseUrl for versions like this:

right now that one returns version 2.0.0 but the real version should be 2.0.0-beta.73

I've been trying this morning to come up with something but I'm very bad at this 🤣