search

AngelProtocolFinance / angelprotocol-web-app

Repo for Angel Protocol's React web app
https://angelprotocol.io
GNU General Public License v3.0
3 stars 6 forks source link

As an Endowment manager, I want to withdraw funds to the wallet of my choosing #1709

Closed SovereignAndrey closed 1 year ago

SovereignAndrey commented 1 year ago

CU Ticket: https://app.clickup.com/t/865bm3825 Assigned To: Version: v1.8

Description of the issue

User Story:
As an Impact Entrepreneur, I want to send funds to the wallet of my choosing so that I can withdraw to my own account or send funds to a third-party

Translation: Make sure the Withdraw Funds page, form, etc matches the Figma design.

0xNeshi commented 1 year ago

Relevant Figma: Desktop: https://www.figma.com/file/sDjoeJ2IFPd9EJ1LI2WMvF/Product-Design?node-id=1790%3A44223&t=MiJ0n0e96rrbOed7-0 Mobile: https://www.figma.com/file/sDjoeJ2IFPd9EJ1LI2WMvF/Product-Design?node-id=1790%3A45469&t=tVpoA8kbTUtpJjiV-0

0xNeshi commented 1 year ago

@SovereignAndrey should "Reason" (for withdrawal) field be removed?

While being a part of our current withdraw form: image

it is not present in Figma, neither "Liquid" nor "Locked" views: image image

0xNeshi commented 1 year ago

@SovereignAndrey presumably, this "clipboard" icon can be used to automatically paste anything that was last added to the user's machine's clipboard (last thing copied)? image

0xNeshi commented 1 year ago

@SovereignAndrey do we still need to display a warning stating The minimum withdrawal for Ethereum & Binance is $20 USDC? This message is missing from Figma. image image

0xNeshi commented 1 year ago

@SovereignAndrey what are the "Start Time" and "Actions" columns' purpose? image

We currently do not have a start_time (or any date type) field when querying withdrawals. Do we just need to update AWS to return it @jp-mariano ?

@SovereignAndrey should Amount column contain the "requested amount" or the "amount received"?

SovereignAndrey commented 1 year ago

@SovereignAndrey do we still need to display a warning stating The minimum withdrawal for Ethereum & Binance is $20 USDC? This message is missing from Figma.

That warning stays in.

SovereignAndrey commented 1 year ago

@SovereignAndrey should "Reason" (for withdrawal) field be removed?

That stays in for the locked withdraws (only used by charities).

SovereignAndrey commented 1 year ago

@SovereignAndrey presumably, this "clipboard" icon can be used to automatically paste anything that was last added to the user's machine's clipboard (last thing copied)?

That's a really strange UI/UX. Drop it for now. :+1:

SovereignAndrey commented 1 year ago

@SovereignAndrey what are the "Start Time" and "Actions" columns' purpose?

I assume "start time" is when the withdraw was submitted. Not sure what "actions" would be. We can drop that for now and add it later.

We currently do not have a start_time (or any date type) field when querying withdrawals. Do we just need to update AWS to return it @jp-mariano ?

Yes, returning a start datetime field would be needed. cc: @jp-mariano.

@SovereignAndrey should Amount column contain the "requested amount" or the "amount received"?

Amount requested would go there.

jp-mariano commented 1 year ago

We currently do not have a start_time (or any date type) field when querying withdrawals. Do we just need to update AWS to return it @jp-mariano ?

Yes, returning a start datetime field would be needed. cc: @jp-mariano.

Yes, we can add a start_time field. This can be made every time a withdraw record is created.

0xNeshi commented 1 year ago

@SovereignAndrey how will the user know which crypto they withdrew when there's no currency indication? Do we add a "Currency" column as in Donations table?

SovereignAndrey commented 1 year ago

@SovereignAndrey how will the user know which crypto they withdrew when there's no currency indication? Do we add a "Currency" column as in Donations table?

It is always USDC being withdrawn from the accounts contract.

0xNeshi commented 1 year ago

@SovereignAndrey presumably, this "clipboard" icon can be used to automatically paste anything that was last added to the user's machine's clipboard (last thing copied)?

That's a really strange UI/UX. Drop it for now. 👍

@SovereignAndrey it seems this icon navigates the user to the Proposal page related to the selected withdrawal. image

SovereignAndrey commented 1 year ago

@SovereignAndrey presumably, this "clipboard" icon can be used to automatically paste anything that was last added to the user's machine's clipboard (last thing copied)?

That's a really strange UI/UX. Drop it for now. 👍

@SovereignAndrey it seems this icon navigates the user to the Proposal page related to the selected withdrawal. image

Ah, okay. Still a bit strange when the label for that column is "Actions", but okay that is doable.

0xNeshi commented 1 year ago

@SovereignAndrey when should this notification appear and what does clicking on it do? image

0xNeshi commented 1 year ago

@jp-mariano since the tables require the addition of the "Load More" btn, we will need to enable the GET /v1/withdraw/{address} endpoint to return paginated results, similar to how GET /v3/endowments/${network} works. Need additional parameters like start, limit, sort.

SovereignAndrey commented 1 year ago

@SovereignAndrey when should this notification appear and what does clicking on it do?

I imagine it appears if there are open withdraws (proposals needing votes/approval) for that endowment.

Clicking the link should take them to the proposals page (ie. decision center page).