AngelProtocolFinance / ap-subgraph

Angel Protocol Subgraph
1 stars 0 forks source link

Vault- & Strategy- related fixes #32

Closed 0xNeshi closed 1 year ago

0xNeshi commented 1 year ago
SovereignAndrey commented 1 year ago

add missing Strategy.address field -> @SovereignAndrey do we even need to track this? It's the only (relevant) field being updated with event VaultConfigUpdated

I'm struggling to remember/figure out why we even allow a Vault strategy & registrar address to change at all. :thinking: Registrar/Local Registrar would be behind a proxy, so it's address shouldn't change. The strategy address linked for a vault shouldn't change, as we'd depreciate/close and strategy rather than move a vault to another strategy.

My vote is to not bother setting/tracking the address and that the strategy key should serve the lookup. Will ask about the above update logic concerns in our group chat to Steve. :+1: