Closed 0xNeshi closed 1 year ago
add missing Strategy.address field -> @SovereignAndrey do we even need to track this? It's the only (relevant) field being updated with event VaultConfigUpdated
I'm struggling to remember/figure out why we even allow a Vault strategy & registrar address to change at all. :thinking: Registrar/Local Registrar would be behind a proxy, so it's address shouldn't change. The strategy address linked for a vault shouldn't change, as we'd depreciate/close and strategy rather than move a vault to another strategy.
My vote is to not bother setting/tracking the address
and that the strategy key should serve the lookup.
Will ask about the above update logic concerns in our group chat to Steve. :+1:
add missingremoved, see https://github.com/AngelProtocolFinance/ap-subgraph/pull/32#issuecomment-1720748853Strategy.address
field -> @SovereignAndrey do we even need to track this? It's the only (relevant) field being updated withevent VaultConfigUpdated
vault.address
assigment.save()
callsregistrar.ts
mapping reexport everything fromlocal-registrar.ts
. Reasoning:Registrar
andLocalRegistrar
share logic, with the former adding new behavior. That means everything defined forlocal-registrar.ts
applies toregistrar.ts
and it's safe to reexport its functions.vault.totalShares
calculations