search

AngelProtocolFinance / ap-subgraph

Angel Protocol Subgraph
1 stars 0 forks source link

Refactoring v2 #5

Closed SovereignAndrey closed 1 year ago

SovereignAndrey commented 1 year ago

First stab at refactoring the SubGraph schema and mappings to allow for processing and tracking more relevant info from the contracts.

0xNeshi commented 1 year ago

@SovereignAndrey

UPDATE: You could try to symbolically link them as well, so as to not need to re-copy them with every contract code change / recompile cycle.

This seems a bit fragile, as it would mean that we wouldn't be able to graph build the code unless the symlinked ABI files are the exact version that was used when the current subgraph configuration was being created. For example, after symlinking ABIs from evm-smart-contracts, I'm unable to build the subgraph code (using yarn build) from this branch because ABIs on my current evm-smart-contracts branch do not contain certain events expected in subgraph.yaml or the events have different signatures (tried on evm-smart-contracts > master branch as well and the same thing occurred).

The contracts we deploy should always be verified, so it should be safe to depend on ABIs downloaded from Etherscan and not on actual ABI files.

Nevertheless, merging this branch as the code within satisfies the requirements, we can address the ABI issue separately.