Angelelz / WinHelloUnlock

KeePass 2 plugin to automatically unlock databases with Windows Hello
MIT License
168 stars 16 forks source link

Error with Keyprovider/Yubikey and composite key #62

Open simwinaga opened 2 years ago

simwinaga commented 2 years ago

Hi, I'm using the WinHelloUnlock Plugin now for a long time without any problem.

Recently we ordered some Yubikeys (Yubikey 5 NFC) to have a MFA for our KP-Database. Now, when i set the yubikey as an additional factor (KeeChallenge_1.5, keyprovider, Yubikey challenge-response) the WinHelloUnlock doesn't work anymore. I can only unlock the db with the master password and the Yubikey.

When i try to re-"create WinHelloUnlock data for this Database" i always get this error:

image

translated: "Error saving the composite key: The value should not be NULL. Parametername: a"

To Reproduce Steps to reproduce the behavior:

  1. Install KeeChallenge Keyprovider for Yubikey
  2. Open (existing) KP-DB with working WinHelloUnlock
  3. File -> Change Master Key
  4. Type (new) Master Password
  5. Tick Expert-Options, Key-File and Yubikey challenge-response
  6. Paste the Secret Key
  7. Save DB
  8. WinHelloUnlock wants to save the new "password"
  9. Fails with above error

(And like i said, recreate the WinHelloUnlock data in the options fails again with the same error)

Win10 21H2 KeePass 2.50 (64bit) - installed Plugins: WinHelloUnlock 1.6.1, KeeChallenge 1.5.0.0, KeePassRPC 1.14.0.0

Angelelz commented 2 years ago

Hello, thanks for the report. Currently this plugin only supports a Composite Key with any combination of Password/KeyFile/WindowsUserAccount as stated in the Readme:

Setup

After installation, open your database and unlock it using your composite key. Unlocking with any combination of Password/KeyFile/WindowsUserAccount is supported. Secure Desktop is supported.

I might add support for other keys (Like MFA) in the future.

simwinaga commented 2 years ago

with future, you mean the near future? :-)