- Additional Parameters in URL authentication code retrieval

AngellusMortis / django_microsoft_auth

Simple app to enable Microsoft Account, Office 365 and Xbox Live authentcation as a Django authentcation backend.

MIT License

137 stars 84 forks source link

- Additional Parameters in URL authentication code retrieval #481

Closed TheCyberFox closed 2 years ago

TheCyberFox commented 2 years ago

Added the ability to include additional parameters in Microsoft authentication code retrieval url creation. The additional parameters you can include are listed within this link https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-auth-code-flow

AngellusMortis commented 2 years ago

Please add tests and docs. You can ignore the CC error (for too many lines in the conf.py file).

TheCyberFox commented 2 years ago

I have no idea what happened with the test_client.py file for it to register like it did. I only added a new feature to the _get_auth_url() method as well as added a test method at the very bottom of the file.

AngellusMortis commented 2 years ago

CI is failing. And yeah, it looks like the docs are out of date on how to test. You can use the CI workflow as a reference:

https://github.com/AngellusMortis/django_microsoft_auth/blob/master/.github/workflows/ci.yml#L42-L52

TheCyberFox commented 2 years ago

Okay, I got 8/9 of the CI tests in the workflow passing on my side. The last CI test seems to be based on format. The errors I am presented with are very minor and I am not quite sure there is a better way of declaring method parameters; if there is I would love to know.

AngellusMortis commented 2 years ago

Just have some linting issues left.

https://github.com/AngellusMortis/django_microsoft_auth/runs/7414490199?check_suite_focus=true#step:5:19

Need to run black and fix the line lengths (if they are still too long).

TheCyberFox commented 2 years ago

Okay, the only check not passing is the CC error about the configuration file which you said I could ignore.