search

AngellusMortis / django_microsoft_auth

Simple app to enable Microsoft Account, Office 365 and Xbox Live authentcation as a Django authentcation backend.
MIT License
137 stars 84 forks source link

Flake8 Failing #494

Closed korverdev closed 1 year ago

korverdev commented 1 year ago

The contribution guide calls for Flake8 to be passing for any new changes, but the existing codebase raises a significant number of Flake8 warnings. Once these are addressed, it'd be nice to have a workflow in-place to enforce this guideline.

korverdev commented 1 year ago

I'm going to work on addressing this and putting together a workflow.

AngellusMortis commented 1 year ago

Flake8 is running in CI and it is passing. But it only runs on the default Python and uses pyproject-flake8 so the config can exist in the same pyproject.toml. The maintainer of flake8 refuses to implement pyproject.toml support. It is a lot of drama and I feel like most of it is because he wants to force people to his other project, pre-commit, that he makes money off of.

https://github.com/AngellusMortis/django_microsoft_auth/blob/master/.github/workflows/ci.yml#L38 https://github.com/AngellusMortis/django_microsoft_auth/actions/runs/3550096405/jobs/5963165016

korverdev commented 1 year ago

That's good to know. Appreciate the clarification. Would it be possible to clarify the recommended way to run Flake8, since the way recommended in the existing documentation results in a lot of unintended warnings?

korverdev commented 1 year ago

Closing this since it's a duplicate of https://github.com/AngellusMortis/django_microsoft_auth/issues/487.