search

AngellusMortis / django_microsoft_auth

Simple app to enable Microsoft Account, Office 365 and Xbox Live authentcation as a Django authentcation backend.
MIT License
137 stars 84 forks source link

Fixed overwriting changes to UserAdmin #502

Closed pandafy closed 11 months ago

pandafy commented 1 year ago

Instead of defining a new UserAdmin class to add inline forms, monkey patch existing UserAdmin.

This prevents overwriting changes made to UserAdmin by other Django apps.

pandafy commented 1 year ago

Hey @AngellusMortis! Can we move ahead with this PR?

pandafy commented 11 months ago

@AngellusMortis ping!

AngellusMortis commented 11 months ago

Your PR was accessing a private method from a Django function. Meaning it could break any time. If you want your own user admin, you can easily do the same thing this app does. Load your app after this one, unregister the existing admin and register your own.

AngellusMortis commented 11 months ago

Otherwise, you can find another solution that does not require using Django internals and not pinging me. It is rude.