AngellusMortis / sxm-player

A pluggable SXM music player written in Python
MIT License
30 stars 12 forks source link

SIGINT does not abort CLIPlayer cleanly #8

Open edschindler opened 2 years ago

edschindler commented 2 years ago

Description

Using CLIPlayer, when I exit with control/C it's fine. If I send a SIGINT to the parent process, the terminal is left in a non-echoing state (reflecting, I think, the password input, which does not echo). There is a more complete reset on control/C than SIGINT, but they should probably work the same.

But perhaps I should be sending SIGINT to one of the four child processes? A more insistent SIGnal?

The Feature Request part of this (and why I'm sending the SIGINT in the first place) is for CLIPlayer to have a --duration option, which would facilitate DVR-style time-shifting. Without --duration, I have to use one cron job to begin recording, and a second to stop it.

(Since I intend to run CLIPlayer from a cron job, the note about the terminal reset above is more of an FYI.)