Support generating android adaptive icons

[vigorox]

Support generating android adaptive icons:

flavorizr:
  flavors:
    flavor_1:
      app:
        name: "myApp"
      android:
        applicationId: "com.xxx.myApp"
        icon: "assets/icon.png"
        iconForeground: "assets/foreground.png"
        iconBackground: "assets/background.png"

The instruction to generate adaptive icons is "android:adaptiveIcons"

[AngeloAvv]

Hey @vigorox , thanks for supporting this project. I have a few questions for you:

• What if we avoid creating a redundant processor for adaptive icons and we put everything into the default android:icons step instead?
• I do agree with having a separate configuration for adaptive icons, what I personally don't like is letting the Android model grow indefinitely: I would create a key named adaptiveIcon which replaces both iconForeground and iconBackground, and then we can move the foreground and background fields into it as follows

flavorizr:
  flavors:
    flavor_1:
      app:
        name: "myApp"
      android:
        applicationId: "com.xxx.myApp"
        icon: "assets/icon.png"
        adaptiveIcon:
          foreground: "assets/foreground.png"
          background: "assets/background.png"

• I'm confused about having path processors, what's the purpose of them? I think you can easily customize the behavior of NewFileStringProcessor to create nested folders if they don't exist. Please triple-check everything to avoid breaking existing processors :sweat_smile:
• I would avoid deleting previously existing icons as not everyone may expect this behavior: adding more lines in the README so people are aware that they should delete these icons manually instead.

What do you think? Thank you!

[vigorox]

Hi AngeloAvv,

I modified based on your suggestions. Please take a look.

Thanks,

[AngeloAvv]

@vigorox please don't squash/force-push your commits, I'll squash them once everything is ready

[vigorox]

Hi AngeloAvv,

I refactored the code based on your review.

If any further change is required, please tell me.

Thanks,

[kbudulski]

@AngeloAvv That's a cool feature and I see few PRs referencing it, where can we expect a new release with adaptive icons included? 🙂

[AngeloAvv]

Hey @kbudulski , I was waiting for feedback from this before releasing a new version of flutter_flavorizr