search

AngeloAvv / flutter_flavorizr

A flutter utility to easily create flavors in your flutter application
https://pub.dev/packages/flutter_flavorizr
MIT License
468 stars 85 forks source link

Play nice with flutter_launcher_icons? #210

Open gazialankus opened 1 year ago

gazialankus commented 1 year ago

Thank you for this package, it solves a lot of issues right off the bat. However, in my experience, using flutter_launcher_icons and its flavor support to create icons works well in Android but in iOS we get the default Flutter icon.

flavorizr uses this: ios/Runner/Assets.xcassets/flavornameAppIcon.appiconset whereas flutter_launcher_icons uses this: ios/Runner/Assets.xcassets/AppIcon-flavorname.appiconset

If the two get in agreement the world would be a much better place!

gazialankus commented 1 year ago

Same thing for flutter_native_splash.

flavorizr uses this: ios/Runner/Assets.xcassets/flavornameLaunchImage.imageset flutter_native_splash uses this: ios/Runner/Assets.xcassets/LaunchImageFlavorname.imageset

gazialankus commented 1 year ago

I guess the easiest way to satisfy this ticket would be to clarify how to prevent flavorizr from touching the icon and launch image, right?

Rishab-ms commented 1 year ago

@gazialankus right...

amrgetment commented 10 months ago

@gazialankus use instructions field in your yaml check available instructions in the docs page

instructions:
  - google:firebase # Google Adds Google Firebase configurations for Android and iOS
wildsurfer commented 10 months ago

+1 for this feature

r2am9d commented 8 months ago

Hi @gazialankus, did you manage to solve this? I am using "flutter_launcher_icons" and "flutter_native_splash" as well.

gazialankus commented 8 months ago

No I'm not using this package anymore.

Rishab-ms commented 8 months ago

Then what are you using?

With Regards, Rishab M S

From: Gazihan Alankus @.> Sent: Sunday, March 10, 2024 4:20:41 PM To: AngeloAvv/flutter_flavorizr @.> Cc: Rishab Sanjay @.>; Comment @.> Subject: Re: [AngeloAvv/flutter_flavorizr] Play nice with flutter_launcher_icons? (Issue #210)

No I'm not using this package anymore.

— Reply to this email directly, view it on GitHubhttps://github.com/AngeloAvv/flutter_flavorizr/issues/210#issuecomment-1987182421, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANJWTUKTVTSQ2E7B7HBKVRDYXQ3IDAVCNFSM6AAAAAA4PKCNQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBXGE4DENBSGE. You are receiving this because you commented.Message ID: @.***>

gazialankus commented 8 months ago

I'm just handling flavors manually. I had followed some tutorials but none had the complete picture back then. Can't find links at the moment, sorry.

Rishab-ms commented 8 months ago

No problem, if you ever find helpful links for manually handling flavors, please let me know, thank you 🙏🏻

With Regards, Rishab M S

From: Gazihan Alankus @.> Sent: Monday, March 11, 2024 9:48:36 AM To: AngeloAvv/flutter_flavorizr @.> Cc: Rishab Sanjay @.>; Comment @.> Subject: Re: [AngeloAvv/flutter_flavorizr] Play nice with flutter_launcher_icons? (Issue #210)

I'm just handling flavors manually. I had followed some tutorials but none had the complete picture back then. Can't find links at the moment, sorry.

— Reply to this email directly, view it on GitHubhttps://github.com/AngeloAvv/flutter_flavorizr/issues/210#issuecomment-1987607097, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANJWTUIL6DSNUDMZWH2GWMTYXUWBZAVCNFSM6AAAAAA4PKCNQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBXGYYDOMBZG4. You are receiving this because you commented.Message ID: @.***>