search

AngeloAvv / flutter_flavorizr

A flutter utility to easily create flavors in your flutter application
https://pub.dev/packages/flutter_flavorizr
MIT License
456 stars 81 forks source link

Fixes add_firebase_build_phase script output paths #248

Closed vinifig closed 6 months ago

vinifig commented 6 months ago

We decided to add Runner/GoogleService-Info.plist file to gitignore so we could avoid conflicts due to a auto-generated file

because of this some errors started to be shown on our CI, and it's because the assets/scripts/darwin/add_firebase_build_phase.rb wasnt defining 'Runner/GoogleService-Info.plist' as an output declaration to the build_phase.

While debugging i found the solution: https://www.rubydoc.info/github/CocoaPods/Xcodeproj/Xcodeproj/Project/Object/PBXShellScriptBuildPhase

Previous output:

name = "Firebase Setup";
outputFileListPaths = (
);
outputPaths = (
);

Fixed output:

name = "Firebase Setup";
outputFileListPaths = (
);
outputPaths = (
"$(SRCROOT)/Runner/GoogleService-Info.plist",
);
AngeloAvv commented 6 months ago

Hey @vinifig , thank you for this PR. Can this be related?

vinifig commented 6 months ago

Hey @vinifig , thank you for this PR. Can this be related?

Hi @AngeloAvv ! Yes, this PR solves the issue #162

AngeloAvv commented 6 months ago

@vinifig I wanted to let you know about #162 because other people claim it should be fixed with input files also. So from your point of view, setting output files should be enough

vinifig commented 6 months ago

@AngeloAvv yes! It solved the issue i was facing within my project by only changing the output files!