AngeloStavrow commented 5 years ago

For maximum compatibility with the Hugo Theme Gallery, we should go through the template files and make sure they meet the guidelines specified in

AngeloStavrow commented 5 years ago

To verify and fix

From the hugoThemes README

The demo of your theme will be available in a subdirectory of the Hugo Themes website and you need to make sure of the following:

[x] If using inline styles, these need to use absolute URLs, for the linked assets to be served properly, e.g. <div style="background: url('{{ "images/background.jpg" | absURL }}')">.
[x] Make sure not to use a forward slash / in the beginning of a URL, because it will point to the host root and Hugo will not generate the correct URL for the demo's assets.
[x] If using external CSS and JS from a CDN, make sure to load these assets over https. Please do not use relative protocol URLs in your theme's templates.

[x] mainSections should be used instead of hardcoded sections for rendering lists.
[x] readFile or readDir should not be used in theme layouts templates, as well as no hardcoded PATHs in the form of: {{ .Site.baseURL }}/something either in templates or in the config of an Example Site.
[x] Never use the deprecated .Page.URL; instead use .Permalink, .RelPermalink, etc.
[ ] Have some kind of theme maintenance process. If a theme demo breaks with the latest Hugo it will be removed from the Theme Showcase (it is the theme author's obligation to make sure that a theme renders with the latest Hugo).
[x] Discourage the use of third party CDNs to serve assets, as it is no longer a good practice in this day and age (fingerprinting, security risk, etc.).

AngeloStavrow commented 4 years ago

Moving the theme maintenance process work to #64 as this requires some discussion with the Hugo community; this work is otherwise done.