search

AngleSharp / AngleSharp.Diffing

A library that makes it possible to compare two AngleSharp node lists and get a list of differences between them.
MIT License
37 stars 6 forks source link

strongly signing anglesharp.diffing #11

Closed egil closed 3 years ago

egil commented 3 years ago

As the other AngleSharp packages are strongly signed, and bUnit users wants it to be that too, I think its time to strongly name diffing as well.

@FlorianRappl do we have a joint key we're using here, and is there anything I need to be aware of wrt setting this up here?

Related: https://github.com/egil/bUnit/issues/316

FlorianRappl commented 3 years ago

Yes we always use this one IIRC: https://github.com/AngleSharp/AngleSharp/blob/devel/src/AngleSharp/Key.snk

I think it "should just work".

FlorianRappl commented 3 years ago

I'd also make a PR to bring this project to GitHub actions.

We are in the process of migrating all projects as the AppVeyor system stopped working and was also a pain to keep maintained.

Would that be fine with you?

egil commented 3 years ago

Would that be fine with you?

Absolutely. Dont hold back. Would also be cool to get Diffing added to the official website. It seems pretty stable by now :)

FlorianRappl commented 3 years ago

Ah yeah. Good pointer with the website!

FlorianRappl commented 3 years ago

Website done!

https://anglesharp.github.io/projects.html

FlorianRappl commented 3 years ago

Done -> I pushed directly into the devel branch and a preview was build.

I also changed the default branch to devel (this is now the default branch for all AngleSharp projects) and renamed dev -> devel. That way its just consistent with the other repositories. I hope that's fine, otherwise we can revert (this way we could also just re-apply the GitBase repo without requiring a change here).

I've added your name to the funding.

egil commented 3 years ago

Thank you Florian.

Im all for keeping things consistent, and dont mind different paradigmes between projects, I'm used to that from working with different customers :)

Did you add the key signing as well?

FlorianRappl commented 3 years ago

Nope - let me just do that, too!

FlorianRappl commented 3 years ago

Key added and pushed. Hope I did not screw up ...

egil commented 3 years ago

Something broke in the build. Ill take a look at it. Can also update the references to use the just released anglesharp 0.15

egil commented 3 years ago

Seems like it works correctly now. Thank you for your help @FlorianRappl!