Fix textnode path

[edxlhornung]

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

• [x] I have read the CONTRIBUTING document
• [x] My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

• [ ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
• [x] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
• [x] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] My change requires a change to the documentation
• [ ] I have updated the documentation accordingly
• [x] I have added tests to cover my changes
• [ ] All new and existing tests passed

Description

Please see #20 as it contains a good description of the problem and the implementation I did.

The issue was that the index of nodes without children (text and comment) present in the path property of diff nodes was incorrect. This is due to Core.ComparisonSource.GetPathIndex() returning the index inside the Children property (Which does not show nodes without children) instead of the ChildNodes property.

Thus I changed Core.ComparisonSource.GetPathIndex() to return the index inside ChildNodes. I also had to adjust the corresponding test cases in order to accommodate this new change.

[CLAassistant]

All committers have signed the CLA.

[egil]

@FlorianRappl seems like the build script needs a little TLC.

[egil]

Im sorry for the lack of feedback on this. I will try to look at this during the weekend and get back to you @edxlhornung.

[FlorianRappl]

Sorry missed out on it - currently quite a lot of things to do...

[edxlhornung]

No worries! I also had a lot to do so I haven't continued my current projet with the library. I'll probably resume working on it on Monday.

[egil]

Hi and sorry again, travel came in-between of this. Should have time in the beginning of the next week.

[egil]

@FlorianRappl is the build error also an issue in the other AngleSharp repos? I dont have experience with Cake, but a quick google suggests this: https://github.com/cake-build/cake/issues/2262

[FlorianRappl]

@egil just look at AngleSharp.Core and follow the steps there.

AFAIK right now the build is working. If FileHelpers is the issue you can have a look at e.g. AngleSharp.Css.

[egil]

@edxlhornung I think you need to rebase your branch on devel and then the build pipeline should run. I managed to pin the cake addin package versions to something works, so if you do a rebase, we should be able to test your changes.

[FlorianRappl]

You're the man @egil ! Thanks a lot for your efforts here