Closed tomvanenckevort closed 6 months ago
Also another question - what about #87 ? Should we bring this in (the test and fix, if that still applies)?
I think #87 should be merged in devel
first since it's been around for a while, and then I can rebase my branch on that one to ensure my changes work with that fix.
Merged #87 into devel
. Thanks for taking this and putting in the effort @tomvanenckevort !
We're note quite there yet.
I ran some extra tests locally yesterday and realised that the <script type="module">
tags currently don't work. So I need to have another look at that one.
But I guess we can handle that via another PR :)
Yes, I mean it's anyway just a first preview. I've assigned some / relevant issues to the v1 milestone.
I am not sure yet how much I can look into them tonight and on the weekend, but my goal would be to have a bit of focus now on AngleSharp.Js to have this as a 1.0.0. Thanks for your PR and motivating me to do so.
If you want to pick up / anyway have some of these issues handled then please comment on them. Otherwise I'll just pick up whatever is left.
Preview is out (https://www.nuget.org/packages/AngleSharp.Js/0.15.0-beta.16).
The version is still placed at 0.15 and I also noticed that some parts of the NuGet package definition (e.g., the README) are missing: I'll add those and push to devel
.
Awesome work @tomvanenckevort ! I'll hopefully have some timesoon too to check this out and investigate if there's something that Jint could improve too. Just have to get back from vacation first π
Preview is out (https://www.nuget.org/packages/AngleSharp.Js/1.0.0-beta.20); incl. latest target frameworks, correct reference to Jint and AngleSharp, README etc.
I think from the infrastructure POV we are done, now we "only" need to clear the outstanding issues and have it (draw the rest of the owl).
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Description
As discussed in #84 this PR is to cover the upgrade of AngleSharp.Js to use Jint v3.
Changes made:
FunctionInstance
>Function
) to match the changes made in Jint v3.EngineInstance
to remove the lexical and variable environments since those are no longer public in Jint v3. Instead there is now a globalwindow
object which also gets exposed on the global object (to ensure that things likewindow.location.href
andlocation.href
resolve to the same thing).ConsoleInstance
with a newConsole
class that ties it directly to the Window object (as per JS spec).DomDelegateInstance
>ClrFunction
).Also a shoutout to @lahma for providing some guidance and older test code that helped me figure out the global object changes. π