search

Anglepi / My-Many-Reads

Browse books, manage your reads list and find recommendations based on your likings and other users opinions.
GNU General Public License v3.0
3 stars 0 forks source link

Only books _for sale in shops_ have ISBN #96

Closed JJ closed 1 year ago

JJ commented 1 year ago

So compulsorily using a ISBN in all books might need some consideration.

https://github.com/Anglepi/My-Many-Reads/blob/5cbbdb465e96b3b8084626d80d1976b77c2d8593/mmr-backend/book.py#L9

ISBN is not unique; sometimes ISBNs are reused if books are uncatalogued (or for some other reason). If you sell a book in Amazon (or other self-publishing platforms), you might request an ISBN or not. They have an unique ID, however, which they call ASIN. Read all about ISBNs here

At any rate, identifying a book with an (external) ID is not trivial, there are several ways to represent it.

Anglepi commented 1 year ago

I'll just use my internal Id then, and make sure that the passed value is always a number, not a string