AngomRanjan
commented
2 years ago Hi Melanie, Thank you very much for your review and suggestions. It is very much appreciated and I needed it. I have made the first two changes. Can I keep the wrapper for time being as the dateline for the week is near and I'm yet to start the next project? Looking forward to hearing from you. Angom
On Fri, Apr 22, 2022 at 7:33 AM Melanie Arellano @.***> wrote:
@.**** requested changes on this pull request.
Hi @AngomRanjan https://github.com/AngomRanjan ,
GREAT job so far! 🥳 There are some issues that you still need to work on to go to the next project but you are almost there! Highlights
✅ All linters are passing, your project is professional with a proper README. ✅ I was impressed by the look of your project! You made the design look INCREDIBLE ✨ ✅ Your project is one of the best I have seen. Required Changes ♻️
Check the comments under the review. Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In index.html https://github.com/AngomRanjan/Profile/pull/1#discussion_r855706567:
Changes required!
⚠️ The requirements state that "The logo (if the design has one) is on the left and has a link (a tag)". Currently, you have a logo. However, it's just a div with plain text. Make it a link with an tag!
In index.html https://github.com/AngomRanjan/Profile/pull/1#discussion_r855707443:
I’m Mariane Glad to see you!
I’m a software developer! I can help you build a product , feature or website Look through some of my work and experience! If you like what you see and have a project you need coded, don’t hestiate to contact me.
LET’S CONNECT
Changes Required!
⚠️ According to the project requirements, "the headline section is a section tag". Kindly correct it and change from a to a . More info? https://www.w3schools.com/tags/tag_section.asp
In index.html https://github.com/AngomRanjan/Profile/pull/1#discussion_r855710511:
+
[OPTIONAL]
♻️ This is the mobile version of your application. You included a wrapper element with a set width to make it look like the mobile version, even when viewed on desktop. You will keep building the application, and add styling to make it look proper on desktop in the future! Therefore, when developing for mobile, instead of adding a wrapper element, resize your own window's width. You can also view it on different screen resolutions using Chrome Developer Tools.
Remove this container, to ensure that there is no "gray border". Don't worry about making it look good on a desktop yet. We are developing Mobile-First! 📱
[image: image] https://user-images.githubusercontent.com/53036416/164581239-6aabf394-a4c8-4cca-9d4c-46a4b7e82220.png
— Reply to this email directly, view it on GitHub https://github.com/AngomRanjan/Profile/pull/1#pullrequestreview-949361833, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXWTX237B5GHCGGSX7LT5ODVGICGBANCNFSM5UA3YTYQ . You are receiving this because you were mentioned.Message ID: @.***>
Profile Setup Milestone-1: Mobile version skeleton