Angry-Pixel / The-Betweenlands

A dark, hostile environment...
http://bit.ly/TheBetweenlands
244 stars 77 forks source link

[BUG] Leads breaks if tying a mob to a TB Fence #1368

Open Shazuli opened 1 year ago

Shazuli commented 1 year ago

Versions

Betweenlands version:

3.9.5

Forge version:

14.23.5.2860

Singleplayer or Multiplayer:

Both.

Installed mods:

The Betweenlands

Description of the problem

How to reproduce:

Tying any mob with a Lead to a "The Betweenlands" Fence block will pop off after a few seconds.

Looking at the code for Fence block it seems you guys don't extend the vanilla classes and just copies from it instead. The comment at the top of the class mentions it's not "extensible", but looking at other project's code they do that just fine. Forestry for example extends the vanilla BlockFence class.

Addendum

Looks like you guys have copied the source code rather than extend from vanilla in a few other classes. BlockSlabBetweenlands and BlockFenceGateBetweenlands for example. Extending the vanilla classes when possible would probably simplify the code a bit and give better interactions with mods and vanilla.

Expected result:

Not breaking.

Actual result:

Breaking.