search

AnguHashBlog / angular-primeng

🅰 Angular Blog Integration Template including PrimeNG: Seamlessly connects to Hashnode's APIs, effortlessly fetching and integrating your blog data. Compatible with any Hashnode blog.
https://angularprimeng.anguhashblog.com/
MIT License
10 stars 5 forks source link

Feature: Style the theme switcher with custom icons #69

Open monacodelisa opened 2 months ago

monacodelisa commented 2 months ago

Type of feature

✨ Feature

Current behavior

Native primeng input switch

Suggested solution

Try to make it like - TechOpenSolve.com

Additional context

No response

I would be willing to submit a PR to fix this issue

github-actions[bot] commented 2 months ago

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

MestiriBaha commented 1 month ago

I was searching and I tried to add icons inside the slider of PrimeNG p-inputSwitch , However, it proved to be quite challenging , I searched on Stack Overflow and checked the documentation, but I don't think anyone has tried it using the Native primeng input switch , So, I began trying to figure out how to create a custom input switch, but I'm not sure if that's the right approach. Do you have any ideas on how to achieve this?

monacodelisa commented 1 month ago

@MestiriBaha its's cool that you were looking into it :) If you have a look at the Assignees section you can see that I have myself assigned to the issue

image

When you see someone assigned on an issue - that means that they are working on it. Typically while there is an assignee the issue is not available for others.

I have already implemented my custom theme-switcher on numerous apps, and I should be implementing it soon but I am working on other projects currently.

I am not surprised that you are not finding tutorials about it, it is a custom theme-switcher that I started working on and I just liked it and have been implementing it on my apps all over :)

If you do want to work on it -> generally there are 2 ways to go about it:

I have done the vanilla JS way, you are welcome to continue exploring, since I am not going to be available to implement it in the next couple of weeks. If you get it done, just submit a PR, and then we can review it and improve or merge :)

Don't worry if you don't get a progress -> I do intend to implement it eventually and I can tag you so you can see the changes

MestiriBaha commented 1 month ago

Thank you for clearing that up ! Honestly, I did notice the assignees section, but somehow it slipped my mind, haha! I'll definitely give the theme switcher a shot