AnguHashBlog / angular-primeng

🅰 Angular Blog Integration Template including PrimeNG: Seamlessly connects to Hashnode's APIs, effortlessly fetching and integrating your blog data. Compatible with any Hashnode blog.
https://angularprimeng.anguhashblog.com/
MIT License
11 stars 5 forks source link

Update the twitter logo to X #71

Closed MestiriBaha closed 2 months ago

MestiriBaha commented 2 months ago

This PR Closes Issue

closes #

Description

I updated the Twitter logo to "X," which is included in the latest PrimeIcons version. Therefore, I updated the package.json file to the latest versions of PrimeNG and PrimeIcons. This is my first time contributing to an open-source project, and I enjoyed working on these issues. However, for this particular issue , there was no defined issue type, so I couldn't follow the contributing guidelines exactly in the branch name

What type of PR is this? (check all applicable)

Mobile & Desktop Screenshots/Recordings

Mobile Version Screenshot : image Desktop Version Screenshot : image

Steps to QA

Added to documentation?

[Optional] Post-deployment tasks

[Specify any post-deployment tasks that need to be performed]

[Optional] What gif best describes this PR or how it makes you feel?

[Embed gif or describe the feeling in plain text]

monacodelisa commented 2 months ago

@MestiriBaha I have mentioned your PR in the closing PR #73 because I wanted to note your involvement and acknowledge that you have worked on the issue. Please make sure to keep your forked repo updated after changes

MestiriBaha commented 2 months ago

@cleancodecraft , Thank you for clarifying ! about not noticing that the issue has already an assignee , I just was so excited to contribute and I felt it was an easy task so I just rush for it ! next time , I will be more attentive about the labels , I appreciate your efforts and I won't hesitate to ask you for any information before submitting a PR 🙂