Angular-RU / angular-ru-sdk

πŸ…°οΈ ngular-RU Software Development Kit
MIT License
73 stars 16 forks source link

fix: use object for data state type agument #1489

Closed R3tep closed 1 year ago

R3tep commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

What is the current behavior?

The compilation is broken on Angular 16 image

Issue Number: N/A

What is the new behavior?

Since the update to angular 16 I have errors with the type of first argument of StateArgumentDecorator With Object instead DataStateClass everything works fine.

Does this PR introduce a breaking change?

splincode commented 1 year ago

but please check unit test before

image
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a40989d) 82.27% compared to head (75d61e7) 82.27%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1489 +/- ## ======================================= Coverage 82.27% 82.27% ======================================= Files 618 618 Lines 8836 8836 Branches 1710 1710 ======================================= Hits 7270 7270 Misses 1484 1484 Partials 82 82 ``` | Flag | Coverage Ξ” | | |---|---|---| | cdk | `79.73% <ΓΈ> (ΓΈ)` | | | jest | `80.83% <ΓΈ> (ΓΈ)` | | | ngxs | `96.34% <100.00%> (ΓΈ)` | | | summary | `82.27% <100.00%> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Angular-RU#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/Angular-RU/angular-ru-sdk/pull/1489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Angular-RU) | Coverage Ξ” | | |---|---|---| | [libs/ngxs/decorators/src/named/named.ts](https://app.codecov.io/gh/Angular-RU/angular-ru-sdk/pull/1489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Angular-RU#diff-bGlicy9uZ3hzL2RlY29yYXRvcnMvc3JjL25hbWVkL25hbWVkLnRz) | `100.00% <100.00%> (ΓΈ)` | | | [libs/ngxs/decorators/src/payload/payload.ts](https://app.codecov.io/gh/Angular-RU/angular-ru-sdk/pull/1489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Angular-RU#diff-bGlicy9uZ3hzL2RlY29yYXRvcnMvc3JjL3BheWxvYWQvcGF5bG9hZC50cw==) | `100.00% <100.00%> (ΓΈ)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.