Angular-RU / angular-ru-sdk

🅰️ ngular-RU Software Development Kit
MIT License
73 stars 16 forks source link

🐞 - `@angular-ru/ngxs` is not compatible with `@ngxs/store` `v18` #1525

Open hakimio opened 2 weeks ago

hakimio commented 2 weeks ago

Which @angular-ru/* package(s) are the source of the bug?

ngxs

Is this a regression?

No

Description

Try to use @angular-ru/ngxs with the newly released @ngxs/store v18. Angular app compilation fails with the following errors:

X [ERROR] TS1238: Unable to resolve signature of class decorator when called as an expression.
  Type 'typeof CountryRepository' has no properties in common with type 'DataStateClass<any, any>'. [plugin angular-compiler]

    src/app/pages/countries/+state/country.repository.ts:8:1:
      8 │ @StateRepository()
        ╵  ~~~~~~~~~~~~~~~~~
splincode commented 2 weeks ago

I don't have time to support that repository, sorry

hakimio commented 2 weeks ago

That's fine. I'll look into it when I have time.

splincode commented 2 weeks ago

Thank you

hakimio commented 2 weeks ago

@splincode @Markiewic to make @angular-ru/ngxs compatible with @ngxs/store v18, I would need to update angular to v16. Is that ok?

splincode commented 2 weeks ago

Sure, you can upgrade to Angular 16