Closed philstopford closed 6 months ago
PR makes the parameters to the methods support nulls being passed in; speculative, not sure if this is correct or the null checks are superfluous......
Thanks again Phil. I haven't closely checked your changes in your PR but I'm confident that they are all for the better.
I'm not sure what the expectation is here from the origin side, but there are a bunch of null checks here that seem to be problematic because the left side makes the comparison always false.
For example, these checks are always false (just a sampling - there are more indicated through this class):
This one gives me pause because PathFromStr() always returns a Paths64 value, so the null check would appear to be meaningless. I've not touched this in my associated work posted in the PR because the inconsistency here makes me wonder which side should be corrected.
Somewhat related, this same null related approach needs a change here:
perhaps to something like this: