AniCricKet / gear-gurus2.0

Apache License 2.0
0 stars 0 forks source link

Gear Gurus 2.0 CSA Mini Project Review Ticket #3

Open hsinaDitaM opened 9 months ago

hsinaDitaM commented 9 months ago

Team

Crossover Score Runtime Initial Plan & Reflection Repositories Analytics
0.85 Link Plan and Retrospective Review Frontend & Backend Frontend & Backend

Individual: Soham

Crossover Score Video Runtime Key Commit(s) Analytics
0.86 Link Link Sorting & Database & Frontend Backend & Frontend

Individual: Mati

Crossover Score Video Runtime Key Commit(s) Analytics
0.845 Link Link Frontend & Backend Frontend & Backend

Individual: Aniket

Crossover Score Video Runtime Key Commit(s) Analytics
0.84 Link Link Backend & Frontend Frontend & Backend
JasoXDDD commented 9 months ago

Individual Review "Haoxuan" grading "Mati"

Individuals Video, Issue(s), Commits(s)

anawandh commented 9 months ago

Individual Review Aditya Ajay Nawandhar grading Soham K

Individuals Video, Issue(s), Commits(s)

The video was good but no audio. the video showed all work could have focused on main points. The demo of the application was great and showed testing using postman.

Writing code for all 4 sorts and also the frontend. Analytics were good as well. 0.86

tanishapatil1234 commented 9 months ago

Team Review "Tanisha" grading "Gear Gurus "

All criteria met, presentation was retrospective about adding animation in the future. The reason I gave above a 0.8 is because they included a table with analytics. This showed understanding of the sorting algorithm to a greater degree and was something not explicitly required.

tanishapatil1234 commented 9 months ago

Individual Review "Tanisha" grading "Aniket"

Individuals Video, Issue(s), Commits(s)

Per check.
(0.8 + 0.8 + 0.9 + 0.9)/4 = 0.85

Freeform comment : Aniket had a good amount of contributions to his team. He mostly worked on the Fibonacci visualization which was unique. He mentioned that he hopes to try more OOP methods in his Java instead of imperative. This shows growth and understanding of the requirements.

AniCricKet commented 9 months ago

Project Summary

Initial Plan

Our initial plan was to build a virtual car website focusing on electric cars from notable brands such as BMW, Chevrolet, Tesla, and Lucid. In terms of the backend, we deployed and rebuilt using Spring, incorporated an image database for car visuals, implemented car classes with inheritance, used a simple database to store car information, and integrated a sorting algorithm. On the frontend, we created an appealing display of cars with images and specifications, maximized layouts and includes for blogs and timeboxing, and built tables for each company. For integration, we developed API endpoints, established communication via AJAX or Fetch API for real-time updates, and implemented a random car generator.

Changes we made to the plan

Originally, we misinterpreted the requirements and thought of this project more as a passion project and that's why our idea was a car showroom. Then, to make our project meet the requirements for sorting algorithms, we sorted the cars by price and showed the comparisons of the different space and time complexities for 4 different sorting algorithms. And to incorporate fibonacci, we made a fibonacci art feature, which designs a unique art piece made out of circles, inspired by wheels, based on a fibonacci sequence.

Issues we ran into:

Fibonacci Problems:

  1. Magic Numbers: There are several magic numbers in the code (e.g., 20 in recursiveDraw, 300 and 200 in recursiveArtWithBinet). These made part of the code difficult to understand and cause confusion.
  2. Random Number Usage: The randomHSLColor method generates random HSL colors. Which sometimes isn't visually appealing
  3. Code Redundancy: There is some redundancy in code, particularly in the initialization of the list of Supplier objects. Which made debugging difficult.
  4. Error Handling: The code does not include error handling for potential issues, such as invalid input for the Fibo constructor or potential exceptions during matrix operations.

Sorting Problems:

  1. Unable to call the car database from another backend file
  2. Unable to sort pictures along with data
  3. Statistics were not being counted properly so I had to do each sort on paper to make sure it was accurate.

Future improvements

Some things we were thinking of were having animations to help the user visualize how the sorting algorithms work, rather than just see the comparisons in time durations and swaps of each. It would show each card visually move across the screen into the correct position.