AniTrend / anitrend-app

Track all your favorite Anime & Manga with AniTrend as it offers anime or manga lookup, tracking and reference powered by AniList
https://anitrend.co
MIT License
197 stars 26 forks source link

"Anime Roles" tab for a Voice Actor (staff) shows instances of Anime Production Roles instead of all instances of anime that they have been in #327

Closed doongs closed 3 years ago

doongs commented 3 years ago

AniTrend Issue Guidelines

Before opening a new issue, please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.

You may find an answer in already closed issues: https://github.com/AniTrend/anitrend-app/issues?q=is%3Aissue+is%3Aclosed

Description Of Bug

Anime Roles tab for a Voice Actor (staff) shows instances of Anime Production Roles instead of all instances of anime that they have been in

Steps To Reproduce

  1. Search for character Ayane Sakura
  2. Click on Anime Roles tab

Expected Behaviour

Missing many shows such as Your Lie in April and Oregairu. This tab is currently only showing the anime which Ayane Sakura has sung the OP or ED for (production role)

Screenshots/Videos

Screenshot_20201023-014601

Anime Roles Tab: Screenshot_20201023-014607

Screenshot_20201023-014610

Additional Context

If you're using the AniList GraphQL API: I suspect the issue is that you are using the staffMedia field within the API, and that field returns media that the staff member had a production role in such as Theme Song Performance, Episode Director, Composer, or something else

Instead use Staff.characters.nodes.media.nodes (not sure if that query is 100% correct, but that's the idea)

issue-label-bot[bot] commented 3 years ago

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.81. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

wax911 commented 3 years ago

Thank you for submitting an bug issue @doongs I will admit, this is something I had never noticed. Also your assumption is spot on, I am using staffMedia for staff. I will probably resolve this in v2.0 since I'm dedicating all my efforts to that instead. I will leave this open in this repo in-case some of the devs want to take a crack at it.

Kindly please use the provided issue templates in future, I have edited your question to follow the issue guidelines :smiley_cat: