search

AniTrend / retrofit-graphql

Retrofit converter which uses annotations to inject .graphql query or mutation files into a request body, along with any variables.
https://anitrend.github.io/retrofit-graphql/
Apache License 2.0
109 stars 19 forks source link

Drop minSdk to 17 again #112

Closed Cilenco closed 4 years ago

Cilenco commented 4 years ago

In 90EC67F2 the minSdk version was changed from 17 to 21 due to changes in the Retrofit library. The Retrofit README states: Retrofit requires at minimum Java 8+ or Android API 21+.

Since it is possible to use Retrofit 2.9.0 on Android < 5.0 by forcing to use OkHtpp 2.12.0 through:

implementation ('com.squareup.okhttp3:okhttp:3.12.0') {
    force = true
}

I think this library should stay on API 17. Any objections to that?

issue-label-bot[bot] commented 4 years ago

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

wax911 commented 4 years ago

Hi @Cilenco, thanks for the feedback! I personally don't have any objections, and don't see why not. I've not used the force option in gradle but I'm guessing that just forces all dependency artifacts of okhttp from group com.squareup.okhttp3 to use v3.12.0?

I could definitely downgrade the min sdk library version to API 17 and release under v0.11.0-alpha02

Cilenco commented 4 years ago

Yeah, that is the exact behavior of the force option. I really would appreciate a v0.11.0-alpha02 release for that.