AniTrend / retrofit-graphql

Retrofit converter which uses annotations to inject .graphql query or mutation files into a request body, along with any variables.
https://anitrend.github.io/retrofit-graphql/
Apache License 2.0
109 stars 19 forks source link

fix overwrite runtime query. #117

Closed MohammedSDev closed 3 years ago

MohammedSDev commented 3 years ago

Pull Request Template

Thank you for contributing! Please take a moment to review our contributing guidelines to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

IMPORTANT: By submitting a patch, you agree to allow the project owners to license your work under the terms of the Apache License.

wax911 commented 3 years ago

Thank you for your pull request @MohammedSDev I see you did not do the following: image

TLDR;

  1. You should always create an issue first before creating a pull request to discuss the problem, otherwise you spend time working something that may already be in the works or allocated to someone else
  2. Your pull request should ALWAYS target the develop branch