search

AnidemDex / Godot-DialogPlugin

🗨️ A Dialog Node for Godot Engine
MIT License
213 stars 11 forks source link

Leaked instances on exit #1

Open AnidemDex opened 3 years ago

AnidemDex commented 3 years ago

For some reason, the plugin doesn't clean itself and its resources even if I free it at exit. This may be due https://github.com/godotengine/godot/issues/45512 (wich will be fixed on 4.0) but I'm not sure. For now it's not generating a major problem, but I should keep track of this.

AnidemDex commented 3 years ago

Update: for some unknow reason, i managed to solve this. I really don't know how I did it

AnidemDex commented 3 years ago

Another Update: Translations inspector added this bug again. Maybe the plugin inspector can't be free at exit since someone is still holding it's reference?

Annotation: maybe i should use weakref to editor plugins

AnidemDex commented 3 years ago

Apparently fixed. Don't instance or reference resources without freeing them

AnidemDex commented 3 years ago

v0.1.4 added this issue again, with a misterious PanelContainer that appears randomly

AnidemDex commented 3 years ago

v0.1.4 added this issue again, with a misterious PanelContainer that appears randomly

Apparently, drag & drop function causes this

AnidemDex commented 3 years ago

v0.2.0 update: The issue is gone.

I'm not closing this just in case.

AnidemDex commented 3 years ago

v0.3 update: Still no leaked instances

Pro tip: Be sure to free any unused instance.

AnidemDex commented 3 years ago

More information: https://github.com/godotengine/godot/issues/21461

AnidemDex commented 3 years ago

v1.0 update: No leaked instances. Another tip: Use signals to avoid orphan nodes.