search

AnidemDex / Godot-DialogPlugin

🗨️ A Dialog Node for Godot Engine
MIT License
213 stars 11 forks source link

Add Visual Novel Example to Example branch #72

Open Crystalwarrior opened 2 years ago

Crystalwarrior commented 2 years ago

Add a visual novel example, including a test timeline showing off blips, background transitions, etc

https://user-images.githubusercontent.com/3470436/148605301-f13dba30-a7c8-411a-b9ea-0696e6005cc8.mp4

.

Crystalwarrior commented 2 years ago

I think it needs more comments to know what you were doing (I can understand what is happening here, but since we're on the examples branch, we need to do it with ELI5 as possible)

I agree. I will excessively comment it once I have the code as modular and nice to read as possible

AnidemDex commented 2 years ago

Gonna merge this branch after you change the "text text text" placeholder with a proper one (like "placeholder text" or just ""). The other two revisions can be made in a different branch

Crystalwarrior commented 2 years ago

A few points:

* Restore `.gdignore` file

* Are `psd`, `xcf`, `lnk` files necessary?

.psd, .xcf, etc. files are not really necessary, they could be distributed separately. Source files can be helpful for creators to understand how the sprites are composed tho.

AnidemDex commented 2 years ago

don't forget to rebase main and force push your branch when you're done to solve merge conflicts

Crystalwarrior commented 2 years ago

Worked on my game, gotta backport a lot of new discoveries I made during its development into this example later

AnidemDex commented 2 years ago

Please, mark it as done when you think is ready to be merged.