search

Anidetrix / rollup-plugin-styles

🎨 Universal Rollup plugin for styles: PostCSS, Sass, Less, Stylus and more.
https://anidetrix.github.io/rollup-plugin-styles
MIT License
245 stars 43 forks source link

fix: a few more const => var #129

Closed tjenkinson closed 4 years ago

tjenkinson commented 4 years ago

Some I missed in https://github.com/Anidetrix/rollup-plugin-styles/pull/128

tjenkinson commented 4 years ago

@Anidetrix any idea what's causing these errors. Looks like the formatting is a bit different now for some reason

Anidetrix commented 4 years ago

@tjenkinson it seems like it used Dart version of Sass, since it has a different formatting. Maybe you didn't have node-sass dependency installed locally for some reason?

tjenkinson commented 4 years ago

Ah interesting. Not sure what happened. Cleared node_modules and npm i fixed it. Have you considered adding the package-lock.json?

codecov[bot] commented 4 years ago

Codecov Report

Merging #129 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          36       36           
  Lines        1022     1022           
  Branches      267      267           
=======================================
  Hits         1017     1017           
  Misses          2        2           
  Partials        3        3
Impacted Files Coverage Δ
src/loaders/postcss/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8307635...69c6b0e. Read the comment docs.

Anidetrix commented 4 years ago

@tjenkinson there's a lock, but this repo uses pnpm, so it's called pnpm-lock.yaml

tjenkinson commented 4 years ago

ah ok, nevermind then :)