search

Anidetrix / rollup-plugin-styles

🎨 Universal Rollup plugin for styles: PostCSS, Sass, Less, Stylus and more.
https://anidetrix.github.io/rollup-plugin-styles
MIT License
242 stars 43 forks source link

fix: correctly resolve file imports with query params #148

Closed rchl closed 3 years ago

rchl commented 3 years ago

Resolves #132

(Do have in mind that I don't know this code very well.)

codecov[bot] commented 3 years ago

Codecov Report

Merging #148 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          36       36           
  Lines        1022     1029    +7     
  Branches      267      283   +16     
=======================================
+ Hits         1017     1024    +7     
  Misses          2        2           
  Partials        3        3
Impacted Files Coverage Δ
src/loaders/postcss/url/index.ts 98.86% <100.00%> (+0.02%) :arrow_up:
src/loaders/postcss/url/resolve.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7532971...d55d5b3. Read the comment docs.

Anidetrix commented 3 years ago

LGTM, although I'll probably change this to use something like query-string, for versatility and expandability sake

rchl commented 3 years ago

Created follow-up PR #149, switching to query-string.