Aniket-Engg / solidity-school

First place for early developers to learn Solidity
366 stars 82 forks source link

Making a library for Calculator Contract #41

Closed Kali-Decoder closed 2 years ago

Kali-Decoder commented 2 years ago

fixes #37

Library is deployed on Polygon Network Here is the address :- "0x84903e57A043d28B5e476dB3cF6F5D9193AF5000"

I make a smart contract from scratch :- so this are the changes

We have to implement this functions in our library

Happy Coding ...

Aniket-Engg commented 2 years ago

Thanks for the PR @Kali-Decoder . Can you please update it according to the problem statement mentioned in https://github.com/Aniket-Engg/solidity-school/issues/37 ? Remove any extra code and add NatSpec wherever required. Solution can be simple as it is intended to be used for learning purpose.

Kali-Decoder commented 2 years ago

Simple means ?? Adding only add , sub , mul, div methods ?? On Tue, 11 Oct 2022 at 2:03 PM, Aniket @.***> wrote:

Thanks for the PR @Kali-Decoder https://github.com/Kali-Decoder . Can you please update it according to the problem statement mentioned in #37 https://github.com/Aniket-Engg/solidity-school/issues/37 ? Remove any extra code and add NatSpec wherever required. Solution can be simple as it is intended to be used for learning purpose.

— Reply to this email directly, view it on GitHub https://github.com/Aniket-Engg/solidity-school/pull/41#issuecomment-1274309134, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATWP7FNFQRHC2UTRB2DCJVTWCUQ5JANCNFSM6AAAAAARAZQI7I . You are receiving this because you were mentioned.Message ID: @.***>

Aniket-Engg commented 2 years ago

Simple means ?? Adding only add , sub , mul, div methods ?? On Tue, 11 Oct 2022 at 2:03 PM, Aniket @.> wrote: Thanks for the PR @Kali-Decoder https://github.com/Kali-Decoder . Can you please update it according to the problem statement mentioned in #37 <#37> ? Remove any extra code and add NatSpec wherever required. Solution can be simple as it is intended to be used for learning purpose. — Reply to this email directly, view it on GitHub <#41 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATWP7FNFQRHC2UTRB2DCJVTWCUQ5JANCNFSM6AAAAAARAZQI7I . You are receiving this because you were mentioned.Message ID: @.>

yes

Aniket-Engg commented 2 years ago

Thanks @Kali-Decoder 🎉