Closed Kali-Decoder closed 2 years ago
Thanks for the PR @Kali-Decoder . Can you please update it according to the problem statement mentioned in https://github.com/Aniket-Engg/solidity-school/issues/37 ? Remove any extra code and add NatSpec wherever required. Solution can be simple as it is intended to be used for learning purpose.
Simple means ?? Adding only add , sub , mul, div methods ?? On Tue, 11 Oct 2022 at 2:03 PM, Aniket @.***> wrote:
Thanks for the PR @Kali-Decoder https://github.com/Kali-Decoder . Can you please update it according to the problem statement mentioned in #37 https://github.com/Aniket-Engg/solidity-school/issues/37 ? Remove any extra code and add NatSpec wherever required. Solution can be simple as it is intended to be used for learning purpose.
— Reply to this email directly, view it on GitHub https://github.com/Aniket-Engg/solidity-school/pull/41#issuecomment-1274309134, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATWP7FNFQRHC2UTRB2DCJVTWCUQ5JANCNFSM6AAAAAARAZQI7I . You are receiving this because you were mentioned.Message ID: @.***>
Simple means ?? Adding only add , sub , mul, div methods ?? … On Tue, 11 Oct 2022 at 2:03 PM, Aniket @.> wrote: Thanks for the PR @Kali-Decoder https://github.com/Kali-Decoder . Can you please update it according to the problem statement mentioned in #37 <#37> ? Remove any extra code and add NatSpec wherever required. Solution can be simple as it is intended to be used for learning purpose. — Reply to this email directly, view it on GitHub <#41 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATWP7FNFQRHC2UTRB2DCJVTWCUQ5JANCNFSM6AAAAAARAZQI7I . You are receiving this because you were mentioned.Message ID: @.>
yes
Thanks @Kali-Decoder 🎉
fixes #37
Library is deployed on Polygon Network Here is the address :- "0x84903e57A043d28B5e476dB3cF6F5D9193AF5000"
I make a smart contract from scratch :- so this are the changes
We have to implement this functions in our library
**add(uint256 a, uint256 b) → uint256
sub(uint256 a, uint256 b) → uint256
mul(uint256 a, uint256 b) → uint256
div(uint256 a, uint256 b) → uint256
mod(uint256 a, uint256 b) → uint256
max(uint256 a, uint256 b) → uint256
min(uint256 a, uint256 b) → uint256**
making also a dummy contract to test library
smart contract using >=0.7.0 <0.9.0 solc compiler form my contract .
deploy smart contract library on polygon
changes are in (Solidity-School > STD-3 > 1_CalculatorUsingLib)
Happy Coding ...